Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providers Improvements #2955

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Providers Improvements #2955

merged 4 commits into from
Aug 2, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Jul 18, 2019

Using the Map object and improving the event listeners handling over all socket-based providers. (this will also fix #2953)

@nivida nivida added Bug Addressing a bug Enhancement Includes improvements or optimizations In Progress Currently being worked on 2.x 2.0 related issues labels Jul 18, 2019
@coveralls
Copy link

coveralls commented Jul 22, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.3% when pulling 734dc14 on providers/performance-improvements into 53d0544 on 2.x.

@nivida nivida removed the In Progress Currently being worked on label Jul 22, 2019
@nivida nivida merged commit 84e343d into 2.x Aug 2, 2019
@nivida nivida deleted the providers/performance-improvements branch August 2, 2019 20:43
@nivida nivida mentioned this pull request Aug 5, 2019
Merged
11 tasks
@alcuadrado alcuadrado mentioned this pull request Sep 16, 2019
Closed
@cgewecke cgewecke mentioned this pull request Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.x 2.0 related issues Bug Addressing a bug Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing removing of the listeners on a timeout (WebsocketProvider)
2 participants
@nivida @coveralls