Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign correct JSON-RPC response to validate on Web3EthereumProvider.send method #2854

Merged
merged 2 commits into from
May 30, 2019

Conversation

JunichiSugiura
Copy link

Description

await connection.send method call to assign a right JSON-RPC response before its validation.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@JunichiSugiura JunichiSugiura changed the title await connection.send method Assign correct JSON-RPC response to validate on Web3EthereumProvider.send method May 29, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.862% when pulling 882aedd on LukeSugiura:hotfix/web3-eth-provider into e485119 on ethereum:1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.862% when pulling 882aedd on LukeSugiura:hotfix/web3-eth-provider into e485119 on ethereum:1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants