Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - 2819 - Block transactions on some instances returns an array of… #2844

Merged
merged 3 commits into from
May 28, 2019
Merged

fix - 2819 - Block transactions on some instances returns an array of… #2844

merged 3 commits into from
May 28, 2019

Conversation

joshstevens19
Copy link
Contributor

… 32 byte transactions hashes so new type is transactions: Transaction[] | string[];

Description

This fixes this issue - #2819

Type of change

Transactions on Block interface can return an array of transaction objects, or 32 Bytes transaction hashes depending on the returnTransactionObjects parameter.

  • Bug fix
  • New feature
  • Breaking change
  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

… 32 byte transactions hashes so new type is transactions: Transaction[] | string[];
@coveralls
Copy link

coveralls commented May 25, 2019

Coverage Status

Coverage remained the same at 95.952% when pulling 846b03b on joshstevens19:fix/2819/types/block into 6961fa2 on ethereum:1.0.

@nivida nivida added the Types Incorrect or missing types label May 28, 2019
@nivida nivida merged commit 5683436 into web3:1.0 May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants