Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3 provider types #2112

Merged
merged 25 commits into from
Dec 11, 2018
Merged

Web3 provider types #2112

merged 25 commits into from
Dec 11, 2018

Conversation

joshstevens19
Copy link
Contributor

web3-providers types written with full tests.

@joshstevens19 joshstevens19 requested a review from nivida December 9, 2018 12:15
@joshstevens19 joshstevens19 mentioned this pull request Dec 9, 2018
Closed
4 tasks
@joshstevens19
Copy link
Contributor Author

@nivida perfect feedback thanks - can you check again and if happy merge it

@nivida nivida merged commit 9c0fb5f into web3:ethereumProvider Dec 11, 2018
@joshstevens19 joshstevens19 mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshstevens19 @nivida