Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthereumProvider ES6 #2001

Merged
merged 25 commits into from
Oct 18, 2018
Merged

EthereumProvider ES6 #2001

merged 25 commits into from
Oct 18, 2018

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 17, 2018

No description provided.

* @constructor
*/
constructor(utils, formatters) {
super('eth_getStorageAt', 3, utils, formatters);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a representation like:

 super(
    'eth_getStorageAt',
    3,
    utils,
    formatters
);

would improve readability of the models.

@frozeman
Copy link
Contributor

You should add the babel conversion process as well.

@frozeman
Copy link
Contributor

frozeman commented Oct 18, 2018

Your builds have a JSON error:

(/home/travis/build/ethereum/web3.js/node_modules/lerna/lib/PackageUtilities.js:131:22)
{ [JSONError: Unexpected token } while parsing '{    "name": "web3-eth",    "namespace' in packages/web3-eth/package.json]
  name: 'JSONError',
  fileName: 'packages/web3-eth/package.json',
  exitCode: 1 }
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: [email protected]

@nivida
Copy link
Contributor Author

nivida commented Oct 18, 2018

You should add the babel conversion process as well.

I think babel will not be required because all "ethereum ready" platforms (browsers & node) are supporting es6. (https://kangax.github.io/compat-table/es6/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants