Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web3-shh.rst #1136

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Update web3-shh.rst #1136

merged 1 commit into from
Nov 13, 2017

Conversation

Boehrner
Copy link
Contributor

Correction of the shh subscription example.

@coveralls
Copy link

coveralls commented Oct 23, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 85.538% when pulling f14261c on Boehrner:patch-1 into 78bdf99 on ethereum:1.0.

@frozeman
Copy link
Contributor

Whisper v5 only has one topic, this might change in v6. @gballet any comment on this?

@gballet
Copy link
Contributor

gballet commented Oct 29, 2017

@frozeman @Boehrner Messages have only one topic, but filters can cover several topics. If you create a filter, you must be able to specify several topics and therefore the array is correct.

@frozeman frozeman merged commit 06d6005 into web3:1.0 Nov 13, 2017
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@Boehrner @nachomazzara
Update web3-shh.rst (web3#1136)
a437d3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Boehrner @coveralls @frozeman @gballet