Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some CI jobs fails occasionally and pass after retry and lots of warning logs make it harder to investigate #6290

Closed
Muhammad-Altabba opened this issue Jul 18, 2023 · 1 comment · Fixed by #6428
Closed

Some CI jobs fails occasionally and pass after retry and lots of warning logs make it harder to investigate #6290

Muhammad-Altabba opened this issue Jul 18, 2023 · 1 comment · Fixed by #6428
Assignees
@avkos
Labels
4.x 4.0 related Bug Addressing a bug Investigate

Comments

@Muhammad-Altabba
Copy link
Contributor

Some of the tests are failing sometimes. Additionally, there are many logs that do not make it easy to investigate the issues.
A sample failing test:
https://github.com/web3/web3.js/actions/runs/5585779852/jobs/10209097808

Regarding the warnings, for example, the following could be handled by adding an optional parameter to the Web3 constructor that prevents consoling this warning.

web3: console.warn
web3: NOTE: web3.js is running without provider. You need to pass a provider in order to interact with the network!
@jdevcs
Copy link
Contributor

jdevcs commented Jul 18, 2023

also stale rule needs to be fixed: https://github.com/web3/web3.js/actions/runs/5585779741/workflow

@mconnelly8 mconnelly8 added Investigate Bug Addressing a bug and removed Discussion labels Aug 8, 2023
@avkos avkos self-assigned this Sep 14, 2023
@avkos avkos mentioned this issue Sep 14, 2023
Merged
17 tasks
avkos added a commit that referenced this issue Sep 18, 2023
@avkos
Fix warning "web3.js is running without provider" #6290 (#6428)
8010a6d 
* fix warning "web3.js is running without provider"

* add changelogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avkos avkos

Labels
4.x 4.0 related Bug Addressing a bug Investigate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warning "web3.js is running without provider" #6290 web3/web3.js
4 participants
@avkos @Muhammad-Altabba @jdevcs @mconnelly8