Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-eth-accounts localStorage access issue #3032

Closed
chaitanyapotti opened this issue Aug 16, 2019 · 1 comment
Closed

web3-eth-accounts localStorage access issue #3032

chaitanyapotti opened this issue Aug 16, 2019 · 1 comment
Assignees
Labels
1.x 1.0 related issues Bug Addressing a bug

Comments

@chaitanyapotti
Copy link
Contributor

Description

We inject an iframe into a website.
When 3rd party cookies are blocked, localStorage is defined but access is restricted.
For more details, please refer to this issue

Expected behavior

Gracefully handle the issue

Actual behavior

uncaught DOM exception

Steps to reproduce the behavior

Please refer to the issue linked to reproduce the error

Error Logs

web3_access

Gists

Versions

  • web3.js: 1.2.1
  • nodejs: 10.16.0
  • browser: Brave with brave shield enabled
  • ethereum node: Infura

I wrote a PR which resolves this issue.

@nivida nivida added 1.x 1.0 related issues Bug Addressing a bug labels Aug 16, 2019
@chaitanyapotti
Copy link
Contributor Author

Looks like this is merged.
Happy to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

No branches or pull requests

3 participants