-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for when localStorage is available but access is restricted #3031
Conversation
Great fix @chaitanyapotti! Hope this gets merged |
Hey @chaitanyapotti! Thanks for this PR. Can you explain a little what it does, and especially, how (the error's checks)? It'd be great to have that info in the code. |
@alcuadrado Here is the relevant documentation |
Thanks for that link @chaitanyapotti. Do you mind adding it as a comment in the function? |
@nivida Hey, any timeline on when this will be released? |
Is this feature detection available in the latest npm package release yet? |
I'm wondering the same. Is there a timeline on this release? EDIT: I confirmed for myself that the code is not yet released. This is blocking me on Brave support right now 😢 |
I ended up using ethers.js which is much more lightweight and doesn't have issues like this |
No description provided.