Merge pull request #2557 from ethereum/issue/2551

DeployTransactionResponse renamed to ContractSendMethod
web3 · Mar 22, 2019 · 22a190c · 22a190c
2 parents 0cb5562 + 557854a
commit 22a190c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/web3-eth-contract/types/index.d.ts b/packages/web3-eth-contract/types/index.d.ts
@@ -33,7 +33,7 @@ export class Contract {
 
     clone(): Contract;
 
-    deploy(options: DeployOptions): DeployTransactionResponse;
+    deploy(options: DeployOptions): ContractSendMethod;
 
     methods: any;
 
@@ -64,9 +64,7 @@ export interface DeployOptions {
     arguments?: any[];
 }
 
-export interface DeployTransactionResponse {
-    array: any[];
-
+export interface ContractSendMethod {
     send(options: SendOptions, callback?: (err: Error, contracts: Contract) => void): PromiEvent<Contract>;
 
     estimateGas(options: EstimateGasOptions, callback?: (err: Error, gas: number) => void): Promise<number>;

diff --git a/packages/web3-eth-contract/types/tests/contract-test.ts b/packages/web3-eth-contract/types/tests/contract-test.ts
@@ -24,7 +24,7 @@ const contract = new Contract('http://localhost:500', {type: 'constructor'});
 // $ExpectType Contract
 contract.clone();
 
-// $ExpectType DeployTransactionResponse
+// $ExpectType ContractSendMethod
 contract.deploy({
     data: '0x12345...',
     arguments: [123, 'My String']