[TASK] Use custom DataHandler command instead of invalid cmdMap #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now the DataHandler command map array has been misused to transport custom `localize` command options relevant for translation with DeepL, processed with a hook implementation and using the original command. TYPO3 v13 hardens the DataHandler even further, which is a really good thing, and breaking fingers of developers mess with the data monster - and loosing [1]. This change switch to a custom DataHandler command and using the hook to handle the command directly by using the public `DataHandler->localize()` method to mitigate the TYPO3 v13 exception thrown by `DataHandler->start()`. Tests and link creation are aligned to use the new command name and omit abitary and invalid options. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/83073
calien666
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the DataHandler command map array has been misused
to transport custom
localizecommand options relevant fortranslation with DeepL, processed with a hook implementation
and using the original command.
TYPO3 v13 hardens the DataHandler even further, which is a
really good thing, and breaking fingers of developers mess
with the data monster - and loosing [1].
This change switch to a custom DataHandler command and using
the hook to handle the command directly by using the public
DataHandler->localize()method to mitigate the TYPO3 v13exception thrown by
DataHandler->start().Tests and link creation are aligned to use the new command
name and omit abitary and invalid options.
[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/83073