[TASK] Make functional tests executable for both core versions #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TASK] Add
typo3/cms-install
as$coreExtensionToLoad
Since TYPO3 v13 the
typo3/cms-install
extension is optionaland typo3/testing-framework no longer defines it as extension
to load (core) in functional tests.
web-vision/deepltranslate-core
requires it for now to ensurethat upgrade wizards can be executed - an oversight from TYPO3
core team.
[TASK] Add dual TYPO3 version support for
SiteBasedTestTrait
The
SiteBasedTestTrait
takes care to write site configurationin functional tests and TYPO3 v13 changed the logic of writing
it. Due to changed structure and the additional SiteSettings
support functional tests failing now with TYPO3 v13.
This change adopts required changed for the SiteBasedTestTrait
while keeping TYPO3 v12 support intact.
[TASK] Use suitable siteconfig writer class in FormalityUpgradeWizard
This change ensures to use the suiting site configuration writer
class depending on the TYYPO3 version which has changed between
TYPO3 v12 and v13.
[TASK] Avoid removed
Bootstrap::initializeLanguageObject()
callThe
Bootstrap::initializeLanguageObject()
has been removed inTYPO3 v13 and is now replaced to ensure working test over all
supported TYPO3 core versions.
[TASK] Mitigate removed
TSFE->getContext()
method inRenderTranslatedFlagInFrontendPreviewMode
TYPO3 removed quite some method of
TSFE
internal or removed them,one of them
getContext()
can be mitigated easily.This change retrieves the context either from TSFE or uses the
GeneralUtility::makeInstance()
to retrieve it within theRenderTranslatedFlagInFrontendPreviewMode
PSR-14 event listener.[TASK] Mitigate deprecated fluid TemplateView in favour of ViewFactoryInterface
Since TYPO3 v13 directly instantiating a concrete view has been
replaced with a more generic
ViewFactoryInterface
along withdefault fluid template based variant.
To keep functional tests hard as possible we need to work around
the deprecation with TYPO3 v13 by using a version check in the
ViewHelper related functional tests to use either the factory or
the old way for dual TYPO3 version compatibility.
[1] https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Feature-104773-GenericViewFactory.html
[TASK] Add TYPO3 v13 code phpstan errors for TYPO3v12 to baseline
PHPStan does not understand or respect TYPO3
version conditional based code to make code
flows based on the TYPO3 version, which leads
to false-positive error reportings.
Until a better solution can be provided, we need
to add them to the depending phpstan baseline file.
Used command(s):