[TASK] Ensure TestCase::setUp() parent call chain in tests
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next `typo3/testing-framework` version `8.x` includes additional integrity checks within the provided abstract test cases. That requires that `setUp()` and `tearDown()` calls needs to hit the parent methods. Some tests overrides the `setUp()` method in tests but fail to call the parent method. This change adds the missing `parent::setUp()` calls to prepare towards upgrading `typo3/testing-framework`.
|
Merging without approval as de-facto no brainer and only testing setup related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next
typo3/testing-frameworkversion8.xincludes additional integrity checks within
the provided abstract test cases.
That requires that
setUp()andtearDown()callsneeds to hit the parent methods. Some tests overrides
the
setUp()method in tests but fail to call theparent method.
This change adds the missing
parent::setUp()calls toprepare towards upgrading
typo3/testing-framework.