Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insights feature #150

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Insights feature #150

merged 2 commits into from
Jan 14, 2025

Conversation

mmadzin
Copy link
Collaborator

@mmadzin mmadzin commented Dec 11, 2024

Insights feature

@mmadzin mmadzin requested a review from jfclere December 11, 2024 13:49
jfclere
jfclere previously approved these changes Jan 14, 2025
Copy link
Contributor

@jfclere jfclere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.

@mmadzin mmadzin dismissed jfclere’s stale review January 14, 2025 12:17

The merge-base changed after approval.

Copy link
Contributor

@jfclere jfclere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still perfect.
The parameter to switch insights debug on/off should be in a separated PR.

@mmadzin mmadzin merged commit 7661a9f into web-servers:main Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants