Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch API: Don't DCHECK on a 302 response with a Location header with empty value. #9453

Merged
merged 1 commit into from
Feb 14, 2018

Commits on Feb 14, 2018

  1. Fetch API: Don't DCHECK on a 302 response with a Location header with…

    … empty value.
    
    Blink was failing a DCHECK when it expected a redirect to be taken because
    the request mode was 'follow' and the response had a redirect status code
    and Location header. However, Chrome's //net considers a Location header
    with an empty value to be the same as no Location header at all. See the
    comments on bug 810288 about net::HttpResponseHeaders::IsRedirect().
    
    WPT tests are added. The spec is unclear (whatwg/url#373)
    but seems to either say to fail with network error or enter a loop of self-redirects
    that will eventually hit the redirect limit and fail with network error.
    Chrome currently fails this test because it treats the Location as
    as non-existent, i.e., not a redirect response.
    
    Bug: 810288,707185
    Change-Id: Iaca93976aaa697380b1542ab45d63c318f5050b0
    Reviewed-on: https://chromium-review.googlesource.com/910753
    Reviewed-by: Yutaka Hirano <[email protected]>
    Reviewed-by: Tsuyoshi Horo <[email protected]>
    Commit-Queue: Matt Falkenhagen <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#536644}
    mfalken authored and chromium-wpt-export-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    d9f70eb View commit details
    Browse the repository at this point in the history