[presentation-api] Stop using EventWatcher for IndexedDB #9046
Conversation
Build PASSEDStarted: 2018-01-18 01:52:46 View more information about this build on: |
| @@ -61,31 +61,43 @@ | |||
|
|
|||
| // Indexed Database | |||
| let db; | |||
| const storeName = 'store-controlling-ua'; | |||
| const checkIndexedDB = () => { | |||
| if ('indexedDB' in window) { | |||
| message = 'Indexed Database is shared by top-level and nested browsing contexts.'; | |||
There was a problem hiding this comment.
Isn't this required by same-origin policy? Do we need to test this here?
There was a problem hiding this comment.
The intention of this is to check if both top-level and nested browsing contexts share the same storage, according to the following spec described in Creating a receiving browsing context:
All nested browsing contexts created by the presented document, i.e. that have the receiving browsing context as their top-level browsing context, [...] MUST also share the same browsing state (storage) for features 5-10 listed above.
| db = null; | ||
| let req = indexedDB.open(dbName, 1), store, transaction; | ||
| return new Promise((resolve, reject) => { | ||
| // The test would fail when the database is already created by the controlling UA |
There was a problem hiding this comment.
According to the IndexedDB spec, you can test for existence of a database by a non-empty version property on the result object.
https://developer.mozilla.org/en-US/docs/Web/API/IDBDatabase
Perhaps the test would be simpler by just checking whether a database already exists (thus indicating whether the database was leaked across receiving browsing contexts).
There was a problem hiding this comment.
That's a good idea. Regarding IndexedDB, we can simply check version of a database. I'll simplify and submit these codes later.
BTW, I'm afraid that the MDN article might be incorrect. With regard to indexedDB.open, the IndexedDB spec says:
If version is not given and no database with that name exists, a new database will be created with version equal to 1.
Anyway, we can still check whether the database has been previously created or not by looking at version of the database.
|
I've update the codes by simplifying how to check IndexedDB. Now EventWatcher is used here again. Many thanks, @mfoltzgoogle! |
|
@mfoltzgoogle Thanks for your review and approval. @tidoust @louaybassbouss Could you review this PR? |
|
@tidoust Thanks! |
This PR fixes the "Creating a receiving browsing context" test again.