Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebIDL] Add tests for iterator objects and prototypes #8796

Merged
merged 1 commit into from
Feb 23, 2018
Merged

[WebIDL] Add tests for iterator objects and prototypes #8796

merged 1 commit into from
Feb 23, 2018

Conversation

TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Dec 25, 2017 •
edited by wpt-pr-bot
Loading

This was referenced Dec 25, 2017
Merged
Merged
@TimothyGu TimothyGu requested a review from bzbarsky December 25, 2017 02:09
@ghost
Copy link

ghost commented Dec 25, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-12-25 02:08:33
Finished: 2017-12-25 02:15:50

View more information about this build on:

annevk
annevk approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine. Are there any browser bugs that need to be filed?

@TimothyGu
Copy link
Member Author

@annevk whatwg/webidl#483 (comment) I cannot test Edge or Safari at this moment.

@TimothyGu TimothyGu merged commit 73f03e3 into web-platform-tests:master Feb 23, 2018
@TimothyGu TimothyGu deleted the webidl-iterator-class-string branch February 23, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@domenic domenic Awaiting requested review from domenic

@jensl jensl Awaiting requested review from jensl

@tobie tobie Awaiting requested review from tobie

@yuki3 yuki3 Awaiting requested review from yuki3

@bzbarsky bzbarsky Awaiting requested review from bzbarsky

Assignees
No one assigned
Labels
webidl wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimothyGu @annevk @wpt-pr-bot