Stop using findMediaFile(...) in LayoutTests #8672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, findMediaFile() helped choose the right extension based
on what the browser could play. Chromium cannot play some proprietary
formats (h264, aac, etc), so this check would choose the .ogv format
in that case.
But things have gotten crufty.
include proprietary codecs
media::RemoveProprietaryMediaTypesAndCodecsForTests()
This makes debugging tests a pain because manual execution doesn't
call this method and its easy to forget that the test wrapper does.
hardcoded the use of an mp4 with proprietary codecs, which worked
because the method in Apple's submission #2 above only changes canPlayType responses,
it doesn't remove the actual support for proprietary codecs.
file mime type without supplying codec info. eg
canPlayType("video/mp4") == "maybe" -> lets use the mp4!
and even chromium will now "maybe" for this now that we no longer
consider mp4 proprietary (though codecs like h264 still are!)
So this patch does the following:
maintains the existing behavior and avoids a massive rebaseline.
and manual runs now behave the same.
with various codecs and are duplicated by content and chrome browser
tests (which is a better place for these checks)
they should run and pass on all platforms (previously just android)
There are still many tests that hard code the use of mp4 files. If we
later desire to see LayoutTests run without proprietary codecs, someone
can transition those tests. No one seems to mind at the moment.
It is also not a goal to make LayoutTests try all the supported codecs.
That is covered by unit/integration tests.
Due to #2 above, a handful of tests in external/wpt/media-source now fail
because they use mp4. Fixing these failures is tracked in Issue 794338.
Change-Id: Ie357ae075c880b78d5ee9e95c1b7cc69d9d8a328
BUG: 327115,746579,787575,568704,794338
Reviewed-on: https://chromium-review.googlesource.com/807604
Reviewed-by: Dale Curtis [email protected]
Reviewed-by: Peter Beverloo [email protected]
Commit-Queue: Chrome Cunningham [email protected]
Cr-Commit-Position: refs/heads/master@{#523821}
This change is