Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigating-across-documents: revisions and additions 010-016 #8558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

navigating-across-documents: revisions and additions 010-016 #8558

wants to merge 2 commits into from

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Dec 4, 2017 •
edited by wpt-pr-bot
Loading

Test Canary Edge 16 Firefox Nightly Safari Tech Preview
form-action-javascript-url-returns-script-element.html ✔ ✔ ✔ ✘
form-action-js-url-direct-call.html ✘ ✘ ✘ ✘
form-action-js-url-doc-write-script-then-navigate-href.html ✘ ✘ ✘ ✘
form-action-js-url-doc-writes-script-element.html ✘ ✘ ✘ ✘
form-action-js-url-doc-writes-script-href-cancels-response-delayed.html ✘ ✘ ✘ ✘
form-action-js-url-evaluated-in-target-nested-browsing-context.html ✘ ✔ ✔ ✘
form-action-js-url-executes-async.html ✘ ✘ ✘ ✘
form-action-js-url-returns-string-with-script-href-cancels-response-delayed.html ✘ ✔ ✔ ✔
href-js-url-evaluated-in-target-nested-browsing-context.html ✘ ✔ ✔ ✘
return-false-no-navigation.html ✔ ✔ ✔ ✔
set-iframe-location-then-navigate-to-href-response-delayed.html ✔ ✔ ✔ ✘
set-iframe-location-then-navigate-to-href.html ✔ ✔ ✔ ✘
set-iframe-src-then-navigate-to-href-response-delayed.html ✘ ✔ ✔ ✘
set-iframe-src-then-navigate-to-href.html ✘ ✔ ✔ ✘

@wpt-pr-bot wpt-pr-bot added the html label Dec 4, 2017
@ghost
Copy link

ghost commented Dec 4, 2017 •
edited by ghost
Loading

Build ERRORED

Started: 2017-12-07 22:36:20
Finished: 2017-12-07 22:44:13

Failing Jobs

  • lint
  • safari:10.0

View more information about this build on:

@rwaldron rwaldron force-pushed the nad-010 branch 4 times, most recently from 85966da to 1717418 Compare December 7, 2017 20:25
@rwaldron rwaldron assigned rwaldron and unassigned rwaldron Dec 7, 2017
@rwaldron rwaldron force-pushed the nad-010 branch 5 times, most recently from dcc3e75 to f8ba239 Compare December 7, 2017 22:20
@ghost
Copy link

ghost commented Jan 10, 2018 •
edited by ghost
Loading

Build PASSED

Started: 2018-01-30 18:33:02
Finished: 2018-01-30 19:07:15

Failing Jobs

  • safari:11.0

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/html/browsers/browsing-the-web/navigating-across-documents/form-action-js-url-doc-write-script-then-navigate-href.html   OK: 1
ERROR: 9
  A navigation via 'javascript: url' code (in form-action-js-url-doc-write-script-then-navigate-href-runner.html) must be evaluated async; to pass this test, that navigation must be aborted by the default href navigation (of the clicked link) before that evaluation can complete. FAIL: 1
 assert_equals: The navigation via 'javascript: url' code was not canceled by the default href navigation. This might occur if the 'javascript:url' code is not evaluated async, and/or the default href navigation does not cancel the navigation via 'javascript: url'. expected true but got false

@rwaldron rwaldron force-pushed the nad-010 branch 5 times, most recently from 1bd21ef to 90246e7 Compare January 19, 2018 17:22
@rwaldron
navigating-across-documents: revisions and explanations for 010-015, …
488bce5 
…plus new tests

commit ad4a48b
Author: Rick Waldron <[email protected]>
Date:   Mon Jan 15 14:23:53 2018 -0500

    Minor nits: use a string for js: url return; file name typo fix;

commit 083c1ee
Author: Rick Waldron <[email protected]>
Date:   Mon Jan 15 13:47:28 2018 -0500

    Replacement: 008.html will be replaced by this test.

commit 6c17335
Author: Rick Waldron <[email protected]>
Date:   Mon Jan 15 13:18:37 2018 -0500

    Major refactor: simplification, eliminate async false positives, consistent test + test-runner.html, convert comment blocks into test names and assertion descriptions

    - Eliminating use of postMessage as a test signaling mechanism serves to "reveal" async false positives.
    - Implement "*-runner.html" machinery for all tests that use an iframe as a "target nested browsing context", this will prevent tests from producing blank screens when run in webkit (where javascript: url code executions ignore target)
    - Compute "*-runner.html" for each test file, instead of maintaining the file name directly in each test file.

commit 43a1f83
Author: Rick Waldron <[email protected]>
Date:   Wed Jan 10 10:52:13 2018 -0500

    Minor fixes

commit 884ada3
Author: Rick Waldron <[email protected]>
Date:   Thu Nov 16 16:31:33 2017 -0500

    navigating-across-documents: additional revisions, and additions 010-017

commit 2826fc1
Author: Rick Waldron <[email protected]>
Date:   Wed Nov 1 15:47:32 2017 -0400

    navigating-across-documents: revisions and explanations for 010-*, 011, 012-*, 013, 014 & 015
@rwaldron
Copy link
Contributor Author

  • Rebased
  • Test results table in the PR description has been updated to reflect the current status of of the results
  • Fixed the lint failure

cc @bzbarsky @zcorpan @annevk

@zcorpan zcorpan mentioned this pull request Feb 5, 2018
Closed
@rwaldron rwaldron mentioned this pull request Mar 26, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

@bzbarsky bzbarsky Awaiting requested review from bzbarsky

@annevk annevk Awaiting requested review from annevk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwaldron @wpt-pr-bot