Don't allow Selection in nodes not in the document; #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the spec and Chrome, and seems to bring us closer to Edge and WebKit as well. It also matches our own behavior for addRange(), which was changed in bug 1341137. For collapse and selectAllChildren, we match the tests and browsers, but the spec is incorrect at the time of this writing: w3c/selection-api#86 The removeAllRanges test hadn't been updated for the spec change. MozReview-Commit-ID: DTK8283k5IP Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1359397 [ci skip]
|
Code reviewed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the spec and Chrome, and seems to bring us closer to Edge
and WebKit as well. It also matches our own behavior for addRange(),
which was changed in bug 1341137.
For collapse and selectAllChildren, we match the tests and browsers, but
the spec is incorrect at the time of this writing:
w3c/selection-api#86
The removeAllRanges test hadn't been updated for the spec change.
MozReview-Commit-ID: DTK8283k5IP
Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1359397 [ci skip]
This change is