Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geometry] Test that DOMMatrix CSS parsing is not exposed in workers #5769

Merged
merged 3 commits into from
May 4, 2017
Merged

[geometry] Test that DOMMatrix CSS parsing is not exposed in workers #5769

merged 3 commits into from
May 4, 2017

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented May 3, 2017 •
edited by wpt-pr-bot
Loading

@wpt-pr-bot
Copy link
Collaborator

Notifying @dirkschulze, @peterjoel, and @tschneidereit. (Learn how reviewing works.)

zcorpan added a commit to w3c/fxtf-drafts that referenced this pull request May 3, 2017
@zcorpan
[geometry] Do not expose CSS parser in workers for DOMMatrix
299ffa6 
Annotate setMatrixValue with [Exposed=Window] and throw TypeError
when DOMMatrix/DOMMatrixReadOnly is constructed with a string
if the current global is not a Window.

Fixes #122.

Tests: web-platform-tests/wpt#5769
This was referenced May 3, 2017
Merged
Closed
@ghost
Copy link

ghost commented May 3, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 9d68b49
Using browser at version BuildID 20170503100422; SourceStamp 82c2d17e74ef9cdf38a5d5ac4eb3ae846ec30ba4
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/geometry-1/DOMMatrix-css-string.worker.html
Subtest Results Messages
OK
DOMMatrix constructor with string argument in worker FAIL assert_true: DOMMatrix should exist expected true got false
DOMMatrixReadOnly constructor with string argument in worker FAIL assert_true: DOMMatrixReadOnly should exist expected true got false
DOMMatrix setMatrixValue in worker FAIL DOMMatrix is not defined

@ghost
Copy link

ghost commented May 3, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 955a5991c499b61faf6ef77283a527597c5d3628
Using browser at version 60.0.3080.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/geometry-1/DOMMatrix-css-string.worker.html
Subtest Results Messages
OK
DOMMatrix constructor with string argument in worker FAIL assert_true: DOMMatrix should exist expected true got false
DOMMatrixReadOnly constructor with string argument in worker FAIL assert_true: DOMMatrixReadOnly should exist expected true got false
DOMMatrix setMatrixValue in worker FAIL DOMMatrix is not defined

@zcorpan zcorpan mentioned this pull request May 3, 2017
Open
foolip
foolip approved these changes May 3, 2017
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

css/geometry-1/DOMMatrix-css-string.worker.js Outdated

['DOMMatrix', 'DOMMatrixReadOnly'].forEach(constr => {
test(() => {
assert_true(constr in self, `${constr} is not supported`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this fails, it will be "assert_true: DOMMatrix is not supported expected true got false". In other words, the description is inverted, if it describes the expected value (maybe "self.${constr} exists") then the message will make sense. Or just no description since there's just one assert_true in the test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to ${constr} should exist

zcorpan added a commit to w3c/fxtf-drafts that referenced this pull request May 4, 2017
@zcorpan
[geometry] Do not expose CSS parser in workers for DOMMatrix
57c9300 
Annotate setMatrixValue with [Exposed=Window] and throw TypeError
when DOMMatrix/DOMMatrixReadOnly is constructed with a string
if the current global is not a Window.

Fixes #122.

Tests: web-platform-tests/wpt#5769
@zcorpan zcorpan merged commit 5629382 into master May 4, 2017
@zcorpan zcorpan deleted the zcorpan/dommatrix-css-parsing branch May 4, 2017 11:43
zcorpan added a commit that referenced this pull request May 19, 2017
@zcorpan
[geometry] Also test new DOMMatrix("") in a worker
ed383bf 
Followup for #5769

Relevant spec change: w3c/fxtf-drafts#141
@zcorpan zcorpan mentioned this pull request May 19, 2017
Merged
zcorpan added a commit that referenced this pull request May 19, 2017
@zcorpan
[geometry] Also test new DOMMatrix("") in a worker
64548d0 
Followup for #5769

Relevant spec change: w3c/fxtf-drafts#141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
geometry infra wg-css wg-svg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcorpan @wpt-pr-bot @foolip @gsnedders