-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache API tests: prepopulate cache in deterministic order #5521
Conversation
Chrome and Firefox differ in the order in which cache keys() are returned. Chrome orders by according to when the put()s were issued. Firefox orders by when the body is complete. The test helper prepopulated_cache_test did not guarantee that these matched, leading to the tests being flaky in Firefox. This change tweaks the helper so that the put()s are processed serially so that the order is deterministic for both. Spec issue: w3c/ServiceWorker#823 BUG=655479 Review-Url: https://codereview.chromium.org/2806793002 Cr-Commit-Position: refs/heads/master@{#463195}
Notifying @inexorabletash and @wanderview. (Learn how reviewing works.) |
Firefox (nightly channel)Testing web-platform-tests at revision e65d020 All results8 tests ran/service-workers/cache-storage/window/cache-add.https.html
/service-workers/cache-storage/window/cache-delete.https.html
/service-workers/cache-storage/window/cache-match.https.html
/service-workers/cache-storage/window/cache-matchAll.https.html
/service-workers/cache-storage/window/cache-put.https.html
/service-workers/cache-storage/window/cache-storage-keys.https.html
/service-workers/cache-storage/window/cache-storage-match.https.html
/service-workers/cache-storage/window/cache-storage.https.html
|
Chrome (unstable channel)Testing web-platform-tests at revision e65d020 All results8 tests ran/service-workers/cache-storage/window/cache-add.https.html
/service-workers/cache-storage/window/cache-delete.https.html
/service-workers/cache-storage/window/cache-match.https.html
/service-workers/cache-storage/window/cache-matchAll.https.html
/service-workers/cache-storage/window/cache-put.https.html
/service-workers/cache-storage/window/cache-storage-keys.https.html
/service-workers/cache-storage/window/cache-storage-match.https.html
/service-workers/cache-storage/window/cache-storage.https.html
|
This should be combined with #5413, but leaving open until that's merged or it will be automatically re-created. |
These tests are now available on w3c-test.org |
Chrome and Firefox differ in the order in which cache keys() are
returned. Chrome orders by according to when the put()s were issued.
Firefox orders by when the body is complete. The test helper
prepopulated_cache_test did not guarantee that these matched, leading
to the tests being flaky in Firefox. This change tweaks the helper so
that the put()s are processed serially so that the order is
deterministic for both.
Spec issue: w3c/ServiceWorker#823
BUG=655479
Review-Url: https://codereview.chromium.org/2806793002
Cr-Commit-Position: refs/heads/master@{#463195}
This change is