[wptrunner] Decouple testdriver infrastructure from testharness #49044
Conversation
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-refactor
branch
from
fcfd0c8
to
0f2c1f4
Compare
wpt-pr-bot
added
infra
wptrunner
| (function() { | ||
| window.__wptrunner_is_test_context = true; |
There was a problem hiding this comment.
This is to say as long as testharnessreport.js is included, it is in test context? Assume reftests won't include this file, this won't be true for them?
There was a problem hiding this comment.
There will be two cases where a document includes testdriver.js without testharness.js:
- "Main" test context for a (print-)reftest or crashtest
- An iframe or popup
Since we want testdriver.js to be usable in case (1) without testharnessreport.js or additional markup, testdriver.js now also defines __wptrunner_message_queue. However, this means __wptrunner_message_queue is defined everywhere and can no longer be used to tell apart the test context from case (2).
Therefore, testharnessreport.js sets an explicit __wptrunner_is_test_context flag to signal the test context to testdriver.js. For reftests/crashtests, the test context will be detected by <link rel=(mis)match> or (for crashtests, which have no other distinguishing features) class=test-wait.
message-queue.js is still served in /resources/testharnessreport.js because testharness tests that don't use testdriver still use __wptrunner_message_queue to report completion.
There was a problem hiding this comment.
I see, but is there a better way to do this? We can wait until your next change to make a decision though.
This no-op refactor will allow other WebDriver executors, not just the testharness executor, to perform testdriver actions.
This will allow non-testharness tests to use `testdriver.js` without needing extra scripts. Evaluating `message-queue.js` is idempotent so that, when using testharness with testdriver, the second inclusion is a no-op. Because resource scripts are cached, the size increase should not meaningfully affect test performance.
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-refactor
branch
from
8e59e23
to
8469799
Compare
Split off from #48486 in preparation for #13183. This PR itself should be a no-op, so it need not block on web-platform-tests/rfcs#211.