Cover changing content targetting :has-slotted and :has-slotted(...) #48317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
commented
Sep 23, 2024
Comment on lines
42
to
56
| test.innerHTML = ' '; | ||
| styles = getComputedStyle(target); | ||
| assert_equals(styles.getPropertyValue('color'), blue); | ||
| test.replaceChildren();; | ||
| styles = getComputedStyle(target); | ||
| assert_equals(styles.getPropertyValue('color'), green); | ||
| const div = document.createElement('div'); | ||
| test.append(div); | ||
| styles = getComputedStyle(target); | ||
| assert_equals(styles.getPropertyValue('color'), fuchsia); | ||
| const node = document.createTextNode(' '); | ||
| test.replaceChildren(node); | ||
| styles = getComputedStyle(target); | ||
| assert_equals(styles.getPropertyValue('color'), blue); | ||
| test.innerHTML = ''; |
There was a problem hiding this comment.
Now with more diverse DOM insertion/update APIs.
keithamus
reviewed
Sep 23, 2024
| @@ -0,0 +1,63 @@ | |||
| <!DOCTYPE HTML> | |||
There was a problem hiding this comment.
Need to rename these files to .tentative.
|
Is the "wpt-chrome-dev-stability" job telling me I've added tests that fail in Chrome? It talks about "flakes", but they fail regularly, as expected, which leaves me unsure what else is needed to get this green. Thoughts? |
Westbrook
force-pushed
the
has-slotted-changing
branch
from
4537185 to
a554454
Compare
Westbrook
force-pushed
the
has-slotted-changing
branch
from
a554454 to
0c500da
Compare
keithamus
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keithamus these are much more complicated for me to compile in my brain, but I'm pretty confident this covers content swapping for the various cases in question here.