Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Credentials: digital-credentials-get Permissions Policy tests #47662

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Aug 19, 2024

Copy link
Contributor

@pkotwicz pkotwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CL looks mostly good. A few questions.

@marcoscaceres marcoscaceres requested a review from pkotwicz August 20, 2024 02:33
Copy link
Contributor

@pkotwicz pkotwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with request to move override-permission-policy tests

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/BE9F7aWKQmeU_dSFXtyAPw/Zkun2ySjS4mmZpUeSELZtQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/BE9F7aWKQmeU_dSFXtyAPw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/BE9F7aWKQmeU_dSFXtyAPw/Zkun2ySjS4mmZpUeSELZtQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/BE9F7aWKQmeU_dSFXtyAPw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-08-22T01:33:33.084Z

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp per earlier review.

@marcoscaceres marcoscaceres merged commit a4dd352 into master Aug 22, 2024
16 of 17 checks passed
@marcoscaceres marcoscaceres deleted the dc_policy branch August 22, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants