-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an initial GitHub Actions config to run Safari stable #47181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it work? Is there an artifacts upload somewhere to inspect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this works it LGTM. For preference I'd have all the steps that are just running shell commands as a single shell script that can be run outside of CI rather than inlining them into the workflow file, but it's not a blocker.
https://github.com/gsnedders/web-platform-tests/actions/runs/9980202391
This largely just matches what Azure Pipelines does, albeit with everything in the workflow instead of split into many actions. This is also arguably overly simplistic, because we really want the workflow to be reusable for multiple browsers, which means we need steps to be conditional — but it seemed easiest to inline everything and iterate from here. (It was, in actuality, ultimately derived from an automatically converted Azure Pipelines config.) |
4ee0870
to
214fe04
Compare
214fe04
to
f4a496b
Compare
OK, well happy for this to be merged as-is. |
f4a496b
to
f367bf2
Compare
We'll likely want to refactor this into a reusable workflow, especially for Safari Technology Preview, but potentially for any other browsers we want to run on GitHub Actions. However, land this without this refactoring, as the important thing is to land this (and migrate away from Azure Pipelines) in the short term due to impending capacity constraints. This will likely fail in the wpt_fyi_notify.yml workflow until web-platform-tests/wpt.fyi@594077b is deployed to wpt.fyi.
This duplicates most of safari_stable.yml, which shows that we really do need to refactor most of this into a reusable workflow, but the short-term win of continuing to have results for Safari outweighs purity here.
f367bf2
to
9dd07d8
Compare
We'll likely want to refactor this into a reusable workflow, especially for Safari Technology Preview, but potentially for any other browsers we want to run on GitHub Actions.
That said, let's start with the simple singular case and make sure this works before adding more complexity.