-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebDriver BiDi] missing unhandledPromptBehavior
#46895
Conversation
Provide missing `unhandledPromptBehavior` capabilities to override default `dismiss` behavior and allow for prompt handling tests.
a54be04
to
e96286a
Compare
@whimboo WDYT? |
@sadym-chromium I think that this makes sense when we want to test prompt handling for the BiDi upgrade path. I would still have to take a closer looks to the changes. What I can see is that Chrome is now always failing the tests because of |
Chromedriver does not yet support dictionary in the |
BREAKING CHANGE: default behavior changed from `ignore` to `dismiss`. Failing WPT tests should be addressed by web-platform-tests/wpt#46895. * Puppeteer failures are expected, as Puppeteer has to be updated after Mapper release to pass `unhandledPromptBehavior: {default: 'ignore'}`. * chromedriver has to pass the capability to Mapper. --------- Signed-off-by: Browser Automation Bot <[email protected]> Co-authored-by: Browser Automation Bot <[email protected]>
@whimboo oops, it was auto-merged. Please still feel free to provide feedback which can be addressed in another PR. |
I'm a bit afraid that all the tests are failing with Firefox now, but maybe it revealed a bug on our side. |
Looks like you don't provide |
Oh, good point. We indeed missed to add this field! I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1904822 to get this fixed soon. |
webdriver/tests/bidi/browsing_context/handle_user_prompt/handle_user_prompt.py
Show resolved
Hide resolved
Also, one other observation: the automatic user prompt handling is not yet included in any spec. There is an open pull request on the WHATWG HTML repository that has not been reviewed yet. Therefore, these changes were not strictly necessary, but they are future-proof. Please note that Firefox has not implemented this feature yet. For tracking purposes, I have filed a bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1905086. |
@sadym-chromium as it looks like that Chromium already supports that would you mind writing wdspec tests for this feature? |
Provide missing `unhandledPromptBehavior` capabilities to override default `dismiss` behavior and allow for prompt handling tests.
The default
unhandledPromptBehavior
falls back todismiss
, which does not allow testing prompt handling. This PR providesignore
unhandledPromptBehavior
to keep the prompts for testing.handler
field tobrowsingContext.userPromptOpened
events.