HTML Focusgroup attribute value rename #46407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5554766
branch
from
4699aa3 to
2f624a1
Compare
In a recent update to the spec (see OpenUI bug openui/open-ui#859 and spec update at https://open-ui.org/components/focusgroup.explainer/ the focusgroup direction have changed from physical descriptions "horizontal" and "vertical" to logical CSS terms that imply the direction limitations adapt to content direction: "inline" and "block". This change (my first), is a simple rename of terms "horizontal" and "vertical" to "inline" and "block" respectively. Other than the attribute value parsing changes and related enums and function names, this change does not actually [yet] consider the inline and block direction when handling directional arrow keys from user input. That will be saved for a future change. Specific changes in this CL: - `FocusgroupFlags::kHorizontal` --> `::kInline` - `FocusgroupFlags::kVertical` --> `::kBlock` - `FocusgroupFlags::kWrapHorizontally` --> `::kWrapInline` - `FocusgroupFlags::kWrapVertically` --> `::kWrapBlock` - `FocusgroupFlags::kWrapVertically` --> `::kWrapBlock` - `FocusgroupDirection::kForwardHorizontal` --> `::kForwardInline` - `FocusgroupDirection::kForwardVertical` --> `::kForwardBlock` - `FocusgroupDirection::kBackwardHorizontal` --> `::kBackwardInline` - `FocusgroupDirection::kBackwardVertical` --> `::kBackwardBlock` - `FocusgroupControllerUtils::IsDirectionHorizontal()` -> `IsDirectionInline()` - `FocusgroupControllerUtils::IsDirectionVertical()` -> `IsDirectionBlock()` Web tests impacted by this change are updated (and the corresponding spec link is also updated). Bug: 4021071 Change-Id: Ic3c9a5dc56c0d48f8c1aa5c5cec3dc70bb1f5687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554766 Commit-Queue: Benjamin Beaudry <[email protected]> Reviewed-by: Benjamin Beaudry <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305376}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5554766
branch
from
2f624a1 to
a357828
Compare
wpt-pr-bot
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent update to the spec (see OpenUI bug
openui/open-ui#859 and spec update at
https://open-ui.org/components/focusgroup.explainer/
the focusgroup direction have changed from physical descriptions
"horizontal" and "vertical" to logical CSS terms that imply the
direction limitations adapt to content direction: "inline" and "block".
This change (my first), is a simple rename of terms "horizontal" and
"vertical" to "inline" and "block" respectively. Other than the
attribute value parsing changes and related enums and function names,
this change does not actually [yet] consider the inline and block
direction when handling directional arrow keys from user input. That
will be saved for a future change.
Specific changes in this CL:
FocusgroupFlags::kHorizontal-->::kInlineFocusgroupFlags::kVertical-->::kBlockFocusgroupFlags::kWrapHorizontally-->::kWrapInlineFocusgroupFlags::kWrapVertically-->::kWrapBlockFocusgroupFlags::kWrapVertically-->::kWrapBlockFocusgroupDirection::kForwardHorizontal-->::kForwardInlineFocusgroupDirection::kForwardVertical-->::kForwardBlockFocusgroupDirection::kBackwardHorizontal-->::kBackwardInlineFocusgroupDirection::kBackwardVertical-->::kBackwardBlockFocusgroupControllerUtils::IsDirectionHorizontal()->IsDirectionInline()FocusgroupControllerUtils::IsDirectionVertical()->IsDirectionBlock()Web tests impacted by this change are updated (and the
corresponding spec link is also updated).
Bug: 4021071
Change-Id: Ic3c9a5dc56c0d48f8c1aa5c5cec3dc70bb1f5687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554766
Commit-Queue: Benjamin Beaudry <[email protected]>
Reviewed-by: Benjamin Beaudry <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1305376}