Web platform tests for deprecatedRenderURLReplacements. #45685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5346173
branch
12 times, most recently
from
13167b0 to
ce33fdb
Compare
This covers:
- Making sure the replacements gets to worklets.
- Incorrect macros being passed.
- Replacements within ads.
- Replacements within component ads.
- Replacements within component auctions.
- Replacements within top level auction.
- Failing when replacements passed in top level and
component auction config.
- All sorts of combinations of ${...} and %%...%%.
Change-Id: I1cb38b9fc1273fce7c04ecdf1695884d91560da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5346173
Reviewed-by: mmenke <[email protected]>
Commit-Queue: Youssef Bourouphael <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1288988}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5346173
branch
from
ce33fdb to
b89649e
Compare
wpt-pr-bot
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers:
component auction config.
Change-Id: I1cb38b9fc1273fce7c04ecdf1695884d91560da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5346173
Reviewed-by: mmenke <[email protected]>
Commit-Queue: Youssef Bourouphael <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1288988}