Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View-transitions should only be allowed when page is visible #45122

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 15, 2024

  • Skip the transition if document becomes hidden
  • Disallow oubound cross-document view transitions when document is
    hidden
  • Skip inbound cross-document view transition if document becomes
    hidden
  • When calling startViewTransition() in a hidden document, start is
    as skipped.

Based on following CSS resolution:
w3c/csswg-drafts#9543 (comment)

Bug: 329302331
Change-Id: Ieef3238240b35c5d7f7f819793f65f71d7d75037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374309
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1273445}

- Skip the transition if document becomes hidden
- Disallow oubound cross-document view transitions when document is
  hidden
- Skip inbound cross-document view transition if document becomes
  hidden
- When calling startViewTransition() in a hidden document, start is
  as skipped.

Based on following CSS resolution:
w3c/csswg-drafts#9543 (comment)

Bug: 329302331
Change-Id: Ieef3238240b35c5d7f7f819793f65f71d7d75037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374309
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1273445}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit de64b61 into master Mar 15, 2024
17 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5374309 branch March 15, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants