Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test to expect shadow trees to find document keyframes #44991

Merged
merged 2 commits into from
Mar 7, 2024
Merged

update test to expect shadow trees to find document keyframes #44991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
598be9d
update test to expect shadow trees to find document keyframes
astearns Mar 7, 2024
c122851
always missing updating comments
astearns Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions css/css-scoping/keyframes-001.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@
<script src="/resources/testharnessreport.js"></script>
<link rel="author" title="Emilio Cobos Álvarez" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-scoping/#selectors-data-model">
<!--
Beware of https://github.com/w3c/csswg-drafts/issues/1995 potentially, but
unlikely, changing the expected result of this test.
-->

<style>
#in-document {
width: 100px;
Expand Down
11 changes: 4 additions & 7 deletions css/css-scoping/keyframes-002.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
<!doctype html>
<title>CSS Test: @keyframes from the document don't apply in the shadow tree.</title>
<title>CSS Test: @keyframes from the document should apply in the shadow tree.</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<link rel="author" title="Emilio Cobos Álvarez" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-scoping/#selectors-data-model">
<!--
Beware of https://github.com/w3c/csswg-drafts/issues/1995 potentially, but
unlikely, changing the expected result of this test.
-->

<style>
@keyframes myanim {
from { background: red; }
Expand All @@ -29,6 +26,6 @@
<div id="in-shadow"></div>
`;

assert_equals(host.shadowRoot.getElementById('in-shadow').getAnimations().length, 0);
}, "@keyframes from the document don't apply in the shadow tree");
assert_equals(host.shadowRoot.getElementById('in-shadow').getAnimations().length, 1);
}, "@keyframes from the document should apply in the shadow tree");
</script>