blink: Fire pageconceal for non-ViewTransition navigations. #44714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5315496
branch
5 times, most recently
from
5e24a77
to
a4faecf
Compare
Fire the pageconceal event for cross-document navigations when there is no ViewTransition. This is dispatched right before sending the CommitNavigation IPC. For ViewTransition, the event is dispatched earlier when running the commit deferring conditions. Bug: 1522213 Change-Id: Ie3b6df0a1c5692c6d8c13330e023e1fac2280073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5315496 Reviewed-by: Joe Mason <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Reviewed-by: Rakina Zata Amni <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1265230}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5315496
branch
from
a4faecf
to
608b77a
Compare
wpt-pr-bot
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fire the pageconceal event for cross-document navigations when there is
no ViewTransition. This is dispatched right before sending the
CommitNavigation IPC. For ViewTransition, the event is dispatched
earlier when running the commit deferring conditions.
Bug: 1522213
Change-Id: Ie3b6df0a1c5692c6d8c13330e023e1fac2280073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5315496
Reviewed-by: Joe Mason <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1265230}