URL: percent encode in fragments #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying @Sebmaster, @domenic, @frewsxcv, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) |
This was referenced Dec 8, 2016
FirefoxTesting revision 22bba88 |
ChromeTesting revision 22bba88 |
|
Tests LGTM tentatively, but hopefully @Sebmaster or I can implement the change in jsdom/whatwg-url and confirm for sure. |
Sebmaster
reviewed
Dec 9, 2016
| "href": "a:/#\u0001\u001f !\"#$%&'()*+,-./09:;<=>?@AZ[\\]^_`az{|}~\u007f\u0080\u0081Éé", | ||
| "hash": "#\u0001\u001f !\"#$%&'()*+,-./09:;<=>?@AZ[\\]^_`az{|}~\u007f\u0080\u0081Éé" | ||
| "href": "a:/#%01%1F !\"#$%&'()*+,-./09:;<=>?@AZ[\\]^_`az{|}~%7F%7F%C2%80%C2%81%C3%89%C3%A9", | ||
| "hash": "#%01%1F !\"#$%&'()*+,-./09:;<=>?@AZ[\\]^_`az{|}~%7F%7F%C2%80%C2%81%C3%89%C3%A9" |
There was a problem hiding this comment.
Is %7F%7F really correct here? whatwg-url would only encode one %7F.
|
👍 Passing |
zcorpan
approved these changes
Dec 9, 2016
annevk
added a commit
to whatwg/url
that referenced
this pull request
Dec 9, 2016
Now all components of a URL can be represented using ASCII strings or integers. Tests: web-platform-tests/wpt#4298. Fixes #150.
|
Additional test at #4344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/url#150.