Synthetic click events and event dispatch #3974
Conversation
|
@dtapuska can you review, and perhaps contribute tests from Blink in this area if there are any? |
|
As a general point, I wonder if these tests should all be sync and more explicitly verify that the behavior indeed happens synchronously. Some of the tests have |
|
They cannot use |
|
Oh, so exceptions thrown in the event handler wouldn't fail the right test, I see. |
|
@annevk the blink ones test a disabled control and that stopPropagation doesn't change activation behaviour. Can you add those to your test? |
|
I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=656976 to get those tests into web-platform-tests. If it's not done by a Blink engineer, we'll probably end up with duplicated tests. It's still too hard to work with web-platfom-tests in Blink, but when it's easier in Blink and elsewhere, I think it'll be reasonable to ask implementers to volunteer to write the web-platform-tests changes more often than not. |
| child.dispatchEvent(new MouseEvent("click")) // does not bubble | ||
| assert_false(input.checked) | ||
| t.done() | ||
| }, "only look at parents when event bubbles") |
There was a problem hiding this comment.
This test name is confusing to me; it reads like the event target should be ignored when the event bubbles. How about "ignore parent when event does not bubble"?
There was a problem hiding this comment.
Isn't that just saying the same thing (the event target in the test doesn't have activation behavior)?
There was a problem hiding this comment.
I mean I read it as the "only" refers to the parents, rather than the bubbles. (In this test the event doesn't bubble.) Anyway, not a critical issue :-)
There was a problem hiding this comment.
I could move "only" to just before "when" I suppose.
| dump.appendChild(input) | ||
| input.onclick = t.step_func_done(() => assert_true(input.checked)) | ||
| input.click() | ||
| }, "basic with click()") |
There was a problem hiding this comment.
Please add a blank line between tests
This is testing some of the scenarios discussed in whatwg/dom#325 and specified in whatwg/dom#342.
Ms2ger
force-pushed
the
annevk/dispatch-click-magic
branch
from
120a9b9
to
c36310c
Compare
There are two major changes here: * Any click event can cause activation behavior to run. No exceptions. * The "click in progress flag" is now restricted to the click() method, as it already is in Firefox. The other changes are editorial: * "Activation behavior" is now associated with an object at all times (and cannot be conditionally associated) * "Legacy-pre-activation behavior" and "legacy-canceled-activation behavior" are now more clearly only relevant for input elements in either the Checkbox or Radio Button state. * Various concepts such as "run synthetic click activation steps" and "nearest activatable element" are gone as they are obsoleted by the DOM Standard or the aforementioned normative changes. Tests related to this change: * web-platform-tests/wpt#3974 * web-platform-tests/wpt#4034 Changes to the DOM Standard that were necessary for this change: * whatwg/dom#342 * whatwg/dom#346 Fixes #1394.
There are two major changes here: * Any click event can cause activation behavior to run. No exceptions. * The "click in progress flag" is now restricted to the click() method, as it already is in Firefox. The other changes are editorial: * "Activation behavior" is now associated with an object at all times (and cannot be conditionally associated) * "Legacy-pre-activation behavior" and "legacy-canceled-activation behavior" are now more clearly only relevant for input elements in either the Checkbox or Radio Button state. * Various concepts such as "run synthetic click activation steps" and "nearest activatable element" are gone as they are obsoleted by the DOM Standard or the aforementioned normative changes. Tests related to this change: * web-platform-tests/wpt#3974 * web-platform-tests/wpt#4034 Changes to the DOM Standard that were necessary for this change: * whatwg/dom#342 * whatwg/dom#346 Fixes whatwg#1394.
This is testing some of the scenarios discussed in
whatwg/dom#325 and specified in
whatwg/dom#342.