Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL: URLSearchParams's size #38655

Merged
merged 1 commit into from
Feb 23, 2023
Merged

URL: URLSearchParams's size #38655

merged 1 commit into from
Feb 23, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 22, 2023

Copy link
Member

@bashi bashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests!

@annevk annevk merged commit 348eb12 into master Feb 23, 2023
@annevk annevk deleted the annevk/usp-size branch February 23, 2023 07:07
annevk added a commit to whatwg/url that referenced this pull request Feb 23, 2023
webkit-commit-queue pushed a commit to cdumez/WebKit that referenced this pull request Feb 25, 2023
https://bugs.webkit.org/show_bug.cgi?id=252749
rdar://105781287

Reviewed by Darin Adler.

Add support for URLSearchParams.size:
- whatwg/url#734
- web-platform-tests/wpt#38655

* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-size.any-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-size.any.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-size.any.js: Added.
(test):
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-size.any.worker-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-size.any.worker.html: Added.
* Source/WebCore/html/URLSearchParams.h:
(WebCore::URLSearchParams::size const):
* Source/WebCore/html/URLSearchParams.idl:

Canonical link: https://commits.webkit.org/260836@main
@GPHemsley GPHemsley removed their request for review August 18, 2024 16:29
@GPHemsley GPHemsley removed their assignment Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants