Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mathml] More tests for frac/mpadded/mspace with specified width/height #38466

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 13, 2023

  • mspace-width-height-001.html: Verify how the attributes are mapped to
    presentational hints and can be overridden by inline style.

  • width-height-004.html: Indirectly verify centering in some layout
    algorithms by checking the positions of their children. In particular,
    this allows to check mfrac with a nonzero linethickness even if
    visually its horizontal bar takes the fully available width.

  • width-height-002.html: Also check that specified width/height style
    allows to override the size implied by the width/height/depth
    mpadded attributes.

  • ignored-properties-001.html, TestExpectations: Mark test as slow and
    remove timeout expectation.

Bug: 1227598
Change-Id: Icd4970606d7f7f02ffd09e990533a0f71bfc2b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4239866
Commit-Queue: Frédéric Wang <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1104670}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

* mspace-width-height-001.html: Verify how the attributes are mapped to
  presentational hints and can be overridden by inline style.

* width-height-004.html: Indirectly verify centering in some layout
  algorithms by checking the positions of their children. In particular,
  this allows to check mfrac with a nonzero linethickness even if
  visually its horizontal bar takes the fully available width.

* width-height-002.html: Also check that specified width/height style
  allows to override the size implied by the width/height/depth
  mpadded attributes.

* ignored-properties-001.html, TestExpectations: Mark test as slow and
  remove timeout expectation.

Bug: 1227598
Change-Id: Icd4970606d7f7f02ffd09e990533a0f71bfc2b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4239866
Commit-Queue: Frédéric Wang <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1104670}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants