Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mathml] Add more tests for layout algorithms with specified width/height #38443

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 10, 2023

This is a followup of [1] with more tests for MathML elements that
have a specified width/height:

  • frac-bar-003.html: Verify that the painted bar takes the specified
    width, not the one of the children.

  • width-height-001.html: Don't skip mtable (in the past the test was
    checking the properties are ignored, but this changed in [1]).

  • width-height-002.html, width-height-003.html: Add tests to verify
    the position where the math content is rendered when a larger
    width/height is specified.

  • TestExpectations: Remove obsolete Failure expectations.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4221437
[2] w3c/mathml-core#75

Bug: 6606
Change-Id: I5ea7c33eed9fde8b53ccd0400e6fcfa5eab055a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233950
Commit-Queue: Frédéric Wang <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1103928}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

…ight

This is a followup of [1] with more tests for MathML elements that
have a specified width/height:

- frac-bar-003.html: Verify that the painted bar takes the specified
  width, not the one of the children.

- width-height-001.html: Don't skip mtable (in the past the test was
  checking the properties are ignored, but this changed in [1]).

- width-height-002.html, width-height-003.html: Add tests to verify
  the position where the math content is rendered when a larger
  width/height is specified.

- TestExpectations: Remove obsolete Failure expectations.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4221437
[2] w3c/mathml-core#75

Bug: 6606
Change-Id: I5ea7c33eed9fde8b53ccd0400e6fcfa5eab055a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233950
Commit-Queue: Frédéric Wang <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1103928}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants