[mathml] Update WPT tests that assume CSS width/height are ignored #38361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 4, 2023
Math WG decided that width/height should be taken into account on all MathML elements [1]. This CL updates the following legacy tests that assume the properties are actually ignored [2]: * `ignored-properties-001.html`: This test was checking the properties are ignored. Remove these checks. * `width-height-001.html`: This test was checking the elements keep the same dimension with or without specifying width, height, inline-size or block-size. Change it to actually verify it does take the specified dimensions. * `display-1.html`: This test was checking that the content of a `<math display=block>` with a specified width is horizontally centered inside a parent div. Now that the width is no longer ignored, instead check that it is horizontally centered within the `math` element. More tests will be added in follow-up CLs to further check the effect of specifying width/height on elements. [1] w3c/mathml-core#75 [2] web-platform-tests/interop#197 (comment) Bug: 6606 Change-Id: I6ff46b7589f27cc16ba81db126a4ceaa3a31ef61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4221437 Reviewed-by: Ian Kilpatrick <[email protected]> Quick-Run: Rob Buis <[email protected]> Commit-Queue: Frédéric Wang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1103391}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4221437
branch
from
56ade71 to
3f96d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math WG decided that width/height should be taken into account on all
MathML elements [1]. This CL updates the following legacy tests that
assume the properties are actually ignored [2]:
ignored-properties-001.html: This test was checking the propertiesare ignored. Remove these checks.
width-height-001.html: This test was checking the elements keep thesame dimension with or without specifying width, height, inline-size
or block-size. Change it to actually verify it does take the specified
dimensions.
display-1.html: This test was checking that the content of a\<math display=block>with a specified width is horizontallycentered inside a parent div. Now that the width is no longer ignored,
instead check that it is horizontally centered within the
mathelement.
More tests will be added in follow-up CLs to further check the effect
of specifying width/height on elements.
[1] w3c/mathml-core#75
[2] web-platform-tests/interop#197 (comment)
Bug: 6606
Change-Id: I6ff46b7589f27cc16ba81db126a4ceaa3a31ef61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4221437
Reviewed-by: Ian Kilpatrick <[email protected]>
Quick-Run: Rob Buis <[email protected]>
Commit-Queue: Frédéric Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1103391}