WPT: Create function to test BFCache not restored reason #38038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 18, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4177970
branch
5 times, most recently
from
4bede13
to
3767e01
Compare
Added a function `assertBFCacheNotRestoredReasonsIfApplicable` that uses the `notRestoredReasons` API. Unlike the helper functions in performance timing API folder, this one only checks the main frame's reasons, which should be good (and concise) enough for most of the BFCache feature WPTs. If the API is not available, the function will return straightaway instead report assertion failure. This CL also modifies back-forward-cache-open-connection.window.js as an example usage of the helper function. Bug: 1408436 Change-Id: Ia6215ae88bc295b9c2d8c164aab78780ded3606c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4177970 Reviewed-by: Fergal Daly <[email protected]> Reviewed-by: Yuzu Saijo <[email protected]> Commit-Queue: Mingyu Lei <[email protected]> Cr-Commit-Position: refs/heads/main@{#1098432}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4177970
branch
from
3767e01
to
aa9c6b6
Compare
|
Some affected tests had slow results: Slow tests
These may be pre-existing or newly slow tests. Slow tests indicate that a test ran very close to the test timeout limit and so may become TIMEOUT-flaky in the future. Consider speeding up the test or breaking it into multiple tests. For help, please tag |
|
created crbug.com/1411564. @KyleJu @DanielRyanSmith can you pls admin merge? Thanks! |
KyleJu
approved these changes
Jan 31, 2023
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
Added a function `assertBFCacheNotRestoredReasonsIfApplicable` that uses the `notRestoredReasons` API. Unlike the helper functions in performance timing API folder, this one only checks the main frame's reasons, which should be good (and concise) enough for most of the BFCache feature WPTs. If the API is not available, the function will return straightaway instead report assertion failure. This CL also modifies back-forward-cache-open-connection.window.js as an example usage of the helper function. Bug: 1408436 Change-Id: Ia6215ae88bc295b9c2d8c164aab78780ded3606c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4177970 Reviewed-by: Fergal Daly <[email protected]> Reviewed-by: Yuzu Saijo <[email protected]> Commit-Queue: Mingyu Lei <[email protected]> Cr-Commit-Position: refs/heads/main@{#1098432} Co-authored-by: Mingyu Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function
assertBFCacheNotRestoredReasonsIfApplicablethatuses the
notRestoredReasonsAPI. Unlike the helper functions inperformance timing API folder, this one only checks the main frame's
reasons, which should be good (and concise) enough for most of the
BFCache feature WPTs.
If the API is not available, the function will return straightaway
instead report assertion failure.
This CL also modifies back-forward-cache-open-connection.window.js
as an example usage of the helper function.
Bug: 1408436
Change-Id: Ia6215ae88bc295b9c2d8c164aab78780ded3606c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4177970
Reviewed-by: Fergal Daly <[email protected]>
Reviewed-by: Yuzu Saijo <[email protected]>
Commit-Queue: Mingyu Lei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1098432}