Update encoded/decoded body length for service-worker responses #37257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 30, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4065971
branch
from
5fab0eb to
59eaf8a
Compare
4 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4065971
branch
3 times, most recently
from
f588061 to
243d4e2
Compare
annevk
reviewed
Dec 8, 2022
Comment on lines
32
to
33
| if (mode === "cors") | ||
| assert_greater_than(entry.decodedBodySize, 0); |
There was a problem hiding this comment.
This is redundant with the asserts above I think.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4065971
branch
3 times, most recently
from
e4bcda3 to
4bb2793
Compare
Instead of relying on the network, count the bytes as they come in and use the sum as the metric, only for service-worker responses. Corresponds to the relevant spec change: https://w3c.github.io/ServiceWorker/#dom-fetchevent-respondwith (search for "encoded size") and to proposed spec change: whatwg/fetch#1556 Bug: 925239 Change-Id: I7d47c4febef61a89128cc50003f9f2058f3c1270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4065971 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Yoav Weiss <[email protected]> Cr-Commit-Position: refs/heads/main@{#1081848}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4065971
branch
from
4bb2793 to
fab7fb6
Compare
annevk
added a commit
to whatwg/fetch
that referenced
this pull request
Jan 25, 2023
The encoded/decoded body size relate to the resource, not to the timing. Tests: web-platform-tests/wpt#37884 & web-platform-tests/wpt#37257. This is part of w3c/resource-timing#220 (comment). Co-authored-by: Anne van Kesteren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the network, count the bytes as they
come in and use the sum as the metric, only for service-worker
responses.
Corresponds to the relevant spec change:
https://w3c.github.io/ServiceWorker/#dom-fetchevent-respondwith
(search for "encoded size")
and to proposed spec change:
whatwg/fetch#1556
Bug: 925239
Change-Id: I7d47c4febef61a89128cc50003f9f2058f3c1270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4065971
Commit-Queue: Noam Rosenthal <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1081848}