Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ErrorEventInit's error's null default value #34741

Merged
merged 1 commit into from
Jul 7, 2022

Commits on Jul 7, 2022

  1. Remove ErrorEventInit's error's null default value

    Per the spec change [1], this removes ErrorEventInit's default value
    of null, which makes the error attribute have no null default.
    
    This change has already shipped on WebKit and Gecko, and the change
    makes Chromium match the spec and other implementations. This is tested
    by this WPT:
    
    wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/document-synthetic-errorevent.html
    
    [1] whatwg/html#7983
    
    Fixed: 1332448
    Change-Id: Ia64a62e8c5739ab278016a94b0c3b0419d6a68f6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749784
    Reviewed-by: Joey Arhar <[email protected]>
    Commit-Queue: Joey Arhar <[email protected]>
    Auto-Submit: Mason Freed <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#1021841}
    mfreed7 authored and chromium-wpt-export-bot committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    15f82e2 View commit details
    Browse the repository at this point in the history