Move ARIA attribute reflection tests from dom/nodes/ to html/dom/ #34299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Jun 3, 2022
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 4, 2022
The test was moved to the new folder in web-platform-tests/wpt#34299 And was renamed in web-platform-tests/wpt#34872 Change-Id: I64a9e23f0628929ff4b03e8430e96dc56666b932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3933015 Reviewed-by: Frédéric Wang <[email protected]> Commit-Queue: Manuel Rego <[email protected]> Cr-Commit-Position: refs/heads/main@{#1054655}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The test was moved to the new folder in web-platform-tests/wpt#34299 And was renamed in web-platform-tests/wpt#34872 Change-Id: I64a9e23f0628929ff4b03e8430e96dc56666b932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3933015 Reviewed-by: Frédéric Wang <[email protected]> Commit-Queue: Manuel Rego <[email protected]> Cr-Commit-Position: refs/heads/main@{#1054655} NOKEYCHECK=True GitOrigin-RevId: 1a8eab305c730f004cdf9553059080d3a82a4344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @annevk suggested in #34194 (comment), this is moving the tests out of the DOM spec folder.
The proposed spec text is being written in HTML spec: whatwg/html#7934
So HTML spec folder looks like a better place.