Tentative test for memory cache behavior #32833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
igrigorik,
plehegar,
snuggs,
yoavweiss and
zqzhang
yoavweiss
reviewed
Feb 28, 2022
| 'use-credentials': {crossOrigin: true, attributes: {crossOrigin: 'use-credentials'}}, | ||
| } | ||
|
|
||
| const loaders = { |
There was a problem hiding this comment.
Can we reuse the existing loaders (maybe with modifications/additions)?
| await remove(); | ||
| else | ||
| t.add_cleanup(remove); | ||
| // await new Promise(resolve => t.step_timeout(resolve, 100)); |
| // await new Promise(resolve => t.step_timeout(resolve, 100)); | ||
| const remove2 = await loaders[as](href, configs[cfg2].attributes); | ||
| t.add_cleanup(remove2); | ||
| await new Promise(resolve => t.step_timeout(resolve, 100)); |
There was a problem hiding this comment.
To reduce the chances of flakiness and the time it takes for these tests to run, it'd be better if for "discard" tests, we'd just use PerfObserver and not a timeout. For "reuse" tests, we don't have a choice, but for that case, I'm not sure if 100ms is enough. Maybe for that case, we can add another unrelated request, and check the results once that request returns? That way, we'd align the "timeout" with the server's responsiveness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#6110
Checking different scenarios of memory cache, to see if browsers behave interoperably.
Using the following variants: