[URL] Split forbidden host/domain code points and add more tests for each #32524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
This was referenced Jan 25, 2022
|
@domenic can you verify these with whatwg-url? From a cursory look this seems good. |
|
It's not clear to me this is actually the direction we want to go per whatwg/url#685 (comment), so I'll hold off on further reviews until we get that clarified. It feels like we jumped to the PRs stage earlier than makes sense. |
domenic
pushed a commit
that referenced
this pull request
Jan 25, 2022
These give much more full coverage for host code points. The expectations will be changed in #32524 to follow the spec change proposed in whatwg/url#685; this initial PR gives us a baseline so we can be clear about what the changes are.
domenic
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
LGTM, will let @annevk push the merge button when he's ready to merge whatwg/url#685
annevk
pushed a commit
to whatwg/url
that referenced
this pull request
Jan 28, 2022
In particular C0 controls and U+007F. Tests: web-platform-tests/wpt#32524. Fixes #319 and fixes #627.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 4, 2022
…reviewers,kershaw Tests will be merged from upstream WPT: web-platform-tests/wpt#32524 Differential Revision: https://phabricator.services.mozilla.com/D137739
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 7, 2022
…reviewers,kershaw Tests will be merged from upstream WPT: web-platform-tests/wpt#32524 Differential Revision: https://phabricator.services.mozilla.com/D137739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.