SVG Text NG: Fix text layout after <svg> transform change #31696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 22, 2021
If 'transform' property of the owner <svg> is changed, and <text> is painted without laying out, the content was painted at a wrong position because the <text> kept positions computed with the old scaling factor. This CL fixes it by invalidating <text> layout on 'transform' changes on the owner <svg>. This CL is similar to crrev.com/942976 but for <svg>, not for containing blocks. Bug: 1271931 Change-Id: Iefc7d9b50a8474ed536be2267ad7e5e237ed2546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293550 Commit-Queue: Kent Tamura <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Commit-Queue: Yoshifumi Inoue <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Reviewed-by: Yoshifumi Inoue <[email protected]> Cr-Commit-Position: refs/heads/main@{#943987}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3293550
branch
from
9899af7
to
2bf21d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'transform' property of the owner <svg> is changed, and <text> is
painted without laying out, the content was painted at a wrong position
because the <text> kept positions computed with the old scaling factor.
This CL fixes it by invalidating <text> layout on 'transform' changes
on the owner <svg>. This CL is similar to crrev.com/942976 but for
<svg>, not for containing blocks.
Bug: 1271931
Change-Id: Iefc7d9b50a8474ed536be2267ad7e5e237ed2546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293550
Commit-Queue: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/main@{#943987}