[SPC] Fixup links and one more test #31687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rsolomakhin - please check the test carefully to see if you're convinced it would pass muster as an SPC transaction if it wasn't for the payment-extension blocking. I'm not sure e.g. if I set the right values for topOrigin vs RP (we block too early for me to tell programmatically). |
rsolomakhin
approved these changes
Nov 19, 2021
secure-payment-confirmation/authentication-cannot-bypass-spc.https.html
Outdated
Show resolved
Hide resolved
stephenmcgruer
force-pushed
the
smcgruer/fixup-links-and-one-more-test
branch
from
99854a7
to
d758f9b
Compare
|
@foolip (cc @past ) - I'm not sure what is happening here, can you take a look? The Chrome failures look like Chrome is crashing before ever getting near the test (i.e. on startup), with GPU errors. Notably Chrome Dev updated to |
|
The failures here were due to #31714, with a workaround now landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.