-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appcache: remove wpt references to appcache #31638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
@valenting FYI. How is appcache removal in Firefox going? Do you think it's ok to move forward with removing these WPT appcache tests? |
I ran the wpt tests locally on Chrome without these changes and got the same errors, so I think this patch is ok. I did a double check of the code as well, and even though I removed some things in the service worker directory, there are no references to anything I removed.
|
0a74fc6
to
b9428b6
Compare
This is mostly a removal, but required some modifications as well. Expectations are updated to remove references to removed tests. Bug: 582750 Change-Id: I4e705f5888d3c8cd3d2cc4859a7a3816de5e88f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283191 Commit-Queue: enne <[email protected]> Reviewed-by: Marijn Kruisselbrink <[email protected]> Cr-Commit-Position: refs/heads/main@{#943332}
b9428b6
to
5127942
Compare
Followed up by email, and Firefox has already removed appcache and disabled these tests. |
The stability jobs are still failing, but judging by the nature of the changes (removing stuff) and #31638 (comment) I'm going to guess that this is an preexisting issue not caused by the changed. I'll admin merge this PR. |
This is mostly a removal, but required some modifications as well.
Expectations are updated to remove references to removed tests.
Bug: 582750
Change-Id: I4e705f5888d3c8cd3d2cc4859a7a3816de5e88f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283191
Commit-Queue: enne <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/main@{#943332}