Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight API: Add test coverage #31592

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 11, 2021

These tests are meant to verify that:

  • UAs must not define any styles for custom highlight pseudo-elements
    in the default UA stylesheet.
  • A custom highlight pseudo-element inherits the styles of its
    originating element.

See https://drafts.csswg.org/css-highlight-api-1/#default-styles

Bug: 1164461
Change-Id: I955f39ee185fe2282d7599c07ff1cdd7df2d7059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3273351
Commit-Queue: Fernando Fiori <[email protected]>
Reviewed-by: Dan Clark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#944166}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3273351 branch 2 times, most recently from 8d0d11d to 5c5c703 Compare November 11, 2021 18:24
These tests are meant to verify that:
 - UAs must not define any styles for custom highlight pseudo-elements
in the default UA stylesheet.
 - A custom highlight pseudo-element inherits the styles of its
originating element.

See https://drafts.csswg.org/css-highlight-api-1/#default-styles

Bug: 1164461
Change-Id: I955f39ee185fe2282d7599c07ff1cdd7df2d7059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3273351
Commit-Queue: Fernando Fiori <[email protected]>
Reviewed-by: Dan Clark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#944166}
@foolip
Copy link
Member

foolip commented Nov 23, 2021

This was blocked by #31714, I'll close and reopen in the hope to get the #31715 workaround, which should unblock this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants