Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for https://github.com/whatwg/url/issues/627 #31431

Closed
wants to merge 1 commit into from
Closed

Add a test for https://github.com/whatwg/url/issues/627 #31431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions url/resources/urltestdata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4853,32 +4853,12 @@
{
"input": "http://\u001F!\"$&'()*+,-.;=_`{}~/",
"base": "about:blank",
"href": "http://\u001F!\"$&'()*+,-.;=_`{}~/",
"origin": "http://\u001F!\"$&'()*+,-.;=_`{}~",
"protocol": "http:",
"username": "",
"password": "",
"host": "\u001F!\"$&'()*+,-.;=_`{}~",
"hostname": "\u001F!\"$&'()*+,-.;=_`{}~",
"port": "",
"pathname": "/",
"search": "",
"hash": ""
"failure": true
},
{
"input": "sc://\u001F!\"$&'()*+,-.;=_`{}~/",
"base": "about:blank",
"href": "sc://%1F!\"$&'()*+,-.;=_`{}~/",
"origin": "null",
"protocol": "sc:",
"username": "",
"password": "",
"host": "%1F!\"$&'()*+,-.;=_`{}~",
"hostname": "%1F!\"$&'()*+,-.;=_`{}~",
"port": "",
"pathname": "/",
"search": "",
"hash": ""
"failure": true
},
"# Hosts and percent-encoding",
{
Expand Down
40 changes: 40 additions & 0 deletions url/url-character-sets.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
function checkHostCodePoint(codePoint, forbidden) {
let caught = false;
try {
new URL("https://%" + codePoint.toString(16));
} catch (e) {
caught = true;
}
assert_equals(caught, forbidden, "percent encoded");
Comment on lines +3 to +8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://web-platform-tests.org/writing-tests/testharness-api.html#assert-throws-js-constructor-func-description would be better although it would require changing the logic a bit. That way we can also assert the exact serialization for when it does need to succeed.

caught = false;
try {
new URL("https://" + String.fromCodePoint(codePoint));
} catch (e) {
caught = true;
}
assert_equals(caught, forbidden, "not percent encoded");
}

function isForbiddenHostCodePoint(codePoint) {
return codePoint <= 0x20
|| codePoint == 0x23
|| codePoint == 0x25
|| codePoint == 0x2F
|| codePoint == 0x3A
|| codePoint == 0x3C
|| codePoint == 0x3E
|| codePoint == 0x3F
|| codePoint == 0x40
|| codePoint == 0x5B
|| codePoint == 0x5C
|| codePoint == 0x5D
|| codePoint == 0x5E
|| codePoint == 0x7C
|| codePoint == 0x7F;
}

for (let codePoint = 0; codePoint <= 0x7f; codePoint++) {
test(() => {
checkHostCodePoint(codePoint, isForbiddenHostCodePoint(codePoint));
}, "https host code point 0x" + codePoint.toString(16) + " (" + String.fromCodePoint(codePoint) + ")")
}