Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that we don't indirectly expose redirect timing #30978

Closed
wants to merge 1 commit into from

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Sep 27, 2021

Exposing connection timing info such as domainLookupStart may expose the
fact that a cross-origin redirect has occured, information which should
be hidden.

This is fixed in whatwg/html#7105, and this
modifies the test to account for the new behavior.

Exposing connection timing info such as domainLookupStart may expose the
fact that a cross-origin redirect has occured, information which should
be hidden.

This is fixed in whatwg/html#7105, and this
modifies the test to account for the new behavior.
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noamr
Copy link
Contributor Author

noamr commented Sep 27, 2021

Will merge once whatwg/html#7105 is approved.

@sefeng211
Copy link
Contributor

I checked the obsolete interface for PerformanceNavigationTiming. It looks like only some of the timings require the cross-origin check such as redirectStart and redirectEnd. For things like domainLookupStart, we don't seem to do the cross-origin check.

What am I missing? Please feel free to educate me, Thanks!

@noamr
Copy link
Contributor Author

noamr commented Sep 30, 2021

I checked the obsolete interface for PerformanceNavigationTiming. It looks like only some of the timings require the cross-origin check such as redirectStart and redirectEnd. For things like domainLookupStart, we don't seem to do the cross-origin check.

What am I missing? Please feel free to educate me, Thanks!

This is a proposed behavior change in the spec, to clarify that navigation timing should behave like resource timing in terms of the TAO-hidden properties. I filed the test and browser bugs together with the proposed spec change. see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants